Areid/hex is bits#148
Merged
Merged
Conversation
nikolaykosarev
left a comment
nikolaykosarev
left a comment
There was a problem hiding this comment.
Looks good but, as you have seen probably, some tests fail.
alastairreid
force-pushed
the
areid/hex-is-bits
branch
from
030ca43 to
a1041ff
Compare
alastairreid
force-pushed
the
areid/hex-is-bits
branch
from
a1041ff to
88d598b
Compare
alastairreid
force-pushed
the
areid/hex-is-bits
branch
from
88d598b to
1efc3a9
Compare
Author
|
All tests now passing. |
nikolaykosarev
approved these changes
Jun 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Literal hex constants like "0xFF" now have type ": Bits(4*digits)".
They used to have type ": Integer".
The --language-version flag gives control over whether this is enabled or not.
I decided on a version instead of having lots of individual flags because I think it will be easier to manage.